move to new signing process for release build and prep for 1.20.0 by JamesWTruher · Pull Request #1625 · PowerShell/PSScriptAnalyzer
PR Summary
The infrastructure at MS has changed with regard to signing, this PR allows us to use it.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but the build seems to be broken. Also wondering whether 1.20.0 would be a better target version since the changes are all small improvements but not fixes
Add binskim scan directory
Also publish nupkg directly from signed directory
and don't publish the out directory, publishing the signed directory is enough
Also try to publish just the nupkg
I've rebased to be up to date.
@bergmeister, @rjmholt, @SydneyhSmith - Chris is suggesting that our next release should perhaps be number 1.20.0 and I wanted everyone to have a chance to provide an opinion. FWIW, I'm ok with 1.20
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- agree that 1.20 seems good
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks about right to me
move to new signing process for release build and prep for 1.19.2
move to new signing process for release build and prep for 1.20.0
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just a small comment about the Write-Host invocations
Co-authored-by: Robert Holt <rjmholt_msft@outlook.com>