Fix BuildModules tests by clcaldwell · Pull Request #1654 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
Contributor
PR Summary
Fixes #1653
Fix failing tests in BuildModules.tests.ps1 .
Move the tests into /Build/ in the central tests dir.
Add a reference to include the new folder path when executing all tests.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
6c91585 to
7ed3b09
Compare
JamesWTruher
approved these changes
JamesWTruher
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this, this seems to be fine. Interestingly, I wasn't getting any failures on MacOS. Can you let me know which platform was having the problem?
rjmholt
approved these changes
25b6548
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
