test for pr checks by t-lipingma · Pull Request #1696 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Closed
Closed
test for pr checks#1696
test for pr checks#1696
Conversation
t-lipingma
commented
Jul 13, 2021
t-lipingma
commented
PR Summary
As you can see,
most of PR failed in some necessary checks and it may lie in the two tests of UseCompatibleTypes.Tests.ps1& UseCompatibleCommands.Tests.ps1.
Now I just revised the comment and created a pr to test it.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
rjmholt
commented
Jul 14, 2021
rjmholt commented
Contributor
This is a worrying error. Annoyingly I can't reproduce it locally, but will see if I can use the CI scripts to do so
rjmholt
commented
Jul 15, 2021
rjmholt commented
Contributor
/azp run
azure-pipelines
Bot
commented
Jul 15, 2021
azure-pipelines Bot commented
Azure Pipelines successfully started running 1 pipeline(s).
rjmholt
commented
Jul 15, 2021
rjmholt commented
Contributor
Closing now that #1697 is merged
rjmholt
closed this
t-lipingma
deleted the
test
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment