◐ Shell
clean mode source ↗

Fix compatibility rule tests by rjmholt · Pull Request #1697 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rjmholt

@rjmholt rjmholt commented

Jul 14, 2021

Copy link Copy Markdown

Contributor

PR Summary

Fixes #1695.

We've been seeing failures in the compatibility rule tests, such as in #1696. This seems to be due to a hashtable key being null, which would be explained by a Pester 5 semantics issue. This attempts to simplify the situation to fix the issue.

PR Checklist

@rjmholt rjmholt force-pushed the fix-compatibility-tests branch from 3abfaf5 to c7be234 Compare

July 14, 2021 19:09

@rjmholt rjmholt merged commit 00e0884 into PowerShell:master

Jul 15, 2021

@rjmholt rjmholt deleted the fix-compatibility-tests branch

July 15, 2021 21:26

@rjmholt

rjmholt commented

Jul 15, 2021

Copy link Copy Markdown

Contributor Author

@rjmholt rjmholt mentioned this pull request

Jul 15, 2021

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UseCompatibleTypes.Tests & UseCompatibleCommands.Tests test failed.

1 participant

@rjmholt