Fix compatibility rule tests by rjmholt · Pull Request #1697 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
rjmholt
commented
Jul 14, 2021
rjmholt
commented
Contributor
PR Summary
Fixes #1695.
We've been seeing failures in the compatibility rule tests, such as in #1696. This seems to be due to a hashtable key being null, which would be explained by a Pester 5 semantics issue. This attempts to simplify the situation to fix the issue.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
rjmholt added 3 commits
rjmholt
mentioned this pull request
rjmholt added 3 commits
rjmholt
force-pushed
the
fix-compatibility-tests
branch
from
3abfaf5 to
c7be234
Compare
rjmholt added 4 commits
rjmholt
merged commit
00e0884
into
PowerShell:master
rjmholt
deleted the
fix-compatibility-tests
branch
rjmholt
commented
Jul 15, 2021
rjmholt commented
Contributor Author
/cc @t-lipingma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment