Be sure not to clobber existing files when installing dotnet. by JamesWTruher · Pull Request #1788 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Conversation
JamesWTruher
commented
Apr 12, 2022
Contributor
This is the same fix as PowerShell/PowerShell#17141
PR Summary
installing a new dotnet will clobber the current executables causing all sorts of trouble (dotnet will stop working entirely)
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
This is the same fix as PowerShell/PowerShell#17141
bergmeister
approved these changes
bergmeister
left a comment
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
e6019da
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
