Sync changes from docs repo by sdwheeler · Pull Request #1814 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
sdwheeler
commented
Jun 30, 2022
Collaborator
PR Summary
Copies the changes from PR MicrosoftDocs/PowerShell-Docs-Modules#74 that fixes issue MicrosoftDocs/PowerShell-Docs-Modules#17.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
sdwheeler
commented
Jun 30, 2022
sdwheeler commented
Collaborator Author
@bergmeister For your review
bergmeister
approved these changes
bergmeister
left a comment
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. It's good we finally put the limitation around scriptblock scope into docs. I'm not sure folks will still understand it though what it means in terms of expected false positives. But this should not block this PR, I think I will take a note to add a couple of known false positives in another PR as it's a frequent source of opened issues (as well as user frustration)
323623d
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
