PSAvoidUsingPositionalParameters: Do not warn on AZ CLI by bergmeister · Pull Request #1846 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Conversation
Collaborator
PR Summary
Fixes #1845
AZ CLI entrypoint recently changed from a batch file to an az.ps1 'script' in latest version 2.40.0, which just passed $args arguments as-is to python so it is still a CLI and not a script with parameters.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister
added this to the
1.21 milestone
bergmeister
commented
Sep 22, 2022
bergmeister commented
Collaborator Author
After an internal review we decided that we should not have it in code but as configuration but can still exclude az by default.
bergmeister added 2 commits
bergmeister
added
the
Area - Rules
label
bergmeister
requested a review
from JamesWTruher
JamesWTruher
approved these changes
JamesWTruher
left a comment
JamesWTruher
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks really good
JamesWTruher
merged commit
e88b4c4
into
PowerShell:master
bergmeister
mentioned this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment