Remove dead code and simplify by bergmeister · Pull Request #1856 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
bergmeister
commented
Oct 27, 2022
bergmeister
commented
Collaborator
PR Summary
I ran code analysis on the solution, which showed unused code. I deliberately left the unused code in variable analysis related files though since those files were a fork of the original PowerShell code and might come in useful at a later time.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister added 7 commits
bergmeister
added
the
Area - Build
label
JamesWTruher
self-requested a review
JamesWTruher
approved these changes
JamesWTruher
left a comment
JamesWTruher
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is probably fine
JamesWTruher
merged commit
bd79460
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment