PSReservedParams - link about_CommonParameters by petervandivier · Pull Request #1908 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Merged
Conversation
petervandivier
commented
Apr 20, 2023
Contributor
Knowing that I'm not allowed to use certain words is more helpful if I have a list of those forbidden words.
PR Summary
I came to this docs page after tripping this PSSA condition. In order to not trip it again, I need a list of words I should avoid. Adds a link to online help for about_CommonParameters
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Knowing that I'm not allowed to use certain words is more helpful if I have a list of those forbidden words.
bergmeister
approved these changes
bergmeister
left a comment
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one suggestion, otherwise LGTM
docs/Rules/ReservedParams.md Outdated
bergmeister
commented
Apr 25, 2023
bergmeister commented
Collaborator
The build issues are pending this PR to be merged, I pinged Jim: #1847
docs/Rules/ReservedParams.md Outdated
Co-authored-by: Mikey Lombardi (He/Him) <michael.t.lombardi@gmail.com>
JamesWTruher
approved these changes
2e77c2a
into
PowerShell:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
