Setup new OneBranch pipeline by andyleejordan · Pull Request #2027 · PowerShell/PSScriptAnalyzer
And some overdue clean-ups.
* Azure Pipelines * Docker containers * AppVeyor * ESRP
* Slight .NET SDK bump to satisfy Component Governance * Update license with OSPO's preferred format * Add self to TSA notification list * Remove containers VS Code extension suggestion
We should not be doing this for the developer/user.
Hey @bergmeister are you still using the Docker containers? I assumed not as they hadn't been updated in years.
Which now comes with PSResourceGet
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!
this looks great to me
Hey @bergmeister are you still using the Docker containers? I assumed not as they hadn't been updated in years.
@andyleejordan Sorry for the late reply. Yes, I find them very useful. The only thing that needs updating is the .NET version, which doesn't happen very often due to having support older PS versions. I've been busy generally but plan to look at new issues and pull requests again soon
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyleejordan Although we are not running Appveyor in CI any more, I am still running it in my fork to check that PowerShell 4 build and test still works (hence why appveyor.psm1 was kept as well)
| @@ -45,6 +49,13 @@ jobs: | |||
| if: matrix.os == 'windows-latest' | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add another 'OS' in the matrix so that there is one windows run for powershell core and one for windows powershell so that it can finisher quicker.
What we've lost with this test approach is that the test job used to be its own job just consuming the binary as artefacts (and the repo checkout because of test files although they should've technically also been an artefact). This ensured that the built binaries were sufficient and weren't relying on something else left lying around from the build