Fix incorrect `-ReportSummary` Pester test grouping by MatejKafka · Pull Request #2057 · PowerShell/PSScriptAnalyzer
Conversation
PR Summary
Fixes grouping of Pester tests where tests for -ReportSummary and a few other parameters were (probably accidentally) nested inside another Describe block. Recommend reviewing the diff locally, GitHub diff rendering is very confused (the commit just removes a level of indentation and moves a single }).
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, you're quite right. Thanks!
andyleejordan
changed the title
Fix incorrect Invoke-ScriptAnalyzer Pester test grouping
Fix incorrect -ReportSummary Pester test grouping
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restarted CI check, if that's green, happy with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters