Invoke-ScriptAnalyzer: Stream diagnostics instead of batching by MatejKafka · Pull Request #2062 · PowerShell/PSScriptAnalyzer
PowerShell / PSScriptAnalyzer Public
-
Notifications
You must be signed in to change notification settings - Fork 409
Merged
Conversation
MatejKafka
commented
Feb 21, 2025
Contributor
PR Summary
Before this PR, diagnostics for all analyzed files in this pipeline step were batched and logged at once. Now, diagnostics are rendered immediately when the processing of a specific file is finished.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
Before this commit, diagnostics for all analyzed files in this pipeline step were batched and logged at once. With this commit, diagnostics are rendered immediately.
andyleejordan
approved these changes
andyleejordan
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah using a generator here instead of collecting everything into an accumlated list seems much better.
56c6ea1
into
PowerShell:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
