Fix for PSUseConsistantWhiteSpace when using statement is present by AlexandraDorey · Pull Request #2091 · PowerShell/PSScriptAnalyzer
PR Summary
The addition of an using statement can cause the PSUseConsistant white space to fail due to how the InternalVisit of the UsingStatementAst is implemented in a slightly different way than other ASTs. See issue 2089 for more details.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
@microsoft-github-policy-service agree
Alexandra Dorey added 2 commits
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey cool, good debugging. Read through your issue, I think you're right and this makes sense. Just approved the tests workflow.
WIP - Fix for PSUseConsistantWhiteSpace when using statement is present
Fix for PSUseConsistantWhiteSpace when using statement is present
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, well done
Co-authored-by: Christoph Bergmeister <c.bergmeister@gmail.com>
Fixed the nits up, I'm not super familiar with github but I assume I can merge my commits into one commit when the PR merges or should I do that in by branch first? Otherwise should be good to merge once the tests run again :)
