Update .NET SDK, PowerShell SDK, Newtonsoft.Json and codeowners by andyleejordan · Pull Request #2143 · PowerShell/PSScriptAnalyzer

Thanks for checking @bergmeister

So for Newtonsoft.Json, minimum version is the one used by oldest supported version of PowerShell, which is now 7.4.13, which now uses Newtonsoft 13.0.4 now so that change is fine: https://github.com/PowerShell/PowerShell/blob/5a6ecbf8c98d6d6193c3dcbed75d3454adbbfd09/src/System.Management.Automation/System.Management.Automation.csproj#L31

👍

Update for minimum PS version patch fine as well.

👍

.NET SDK is not as tightly coupled, I think the major version just cannot be newer than the one used by oldest supported PS version. PS used 8.0.415 but it shouldn't be a problem using a newer patch version since PSSA is not self-contained and always relies on PowerShell's engine for execution of its code: https://github.com/PowerShell/PowerShell/blob/v7.4.13/global.json

Internal release systems were requiring us to update this. To be honest, bug's in their end. The pipeline is supposed to build with rollForward: feature applying, but when their tooling checks if we're up to date, it ignores that (and it's also not actually checking what the pipeline is doing...which was also wrong). I gave up trying to it fixed properly and instead had to pointlessly update these to satisfy their tools and so close bugs being filed against us.

I am getting this error when hovering over new code owner but I trust you have tested this new kind of referencing:

Yeah, it exists, and it should be public, but it seems like GitHub and Microsoft's SSO integration is breaking that for you. My guess is you can't view https://github.com/orgs/PowerShell/teams/extension