Enable IDE0049: PreferBuiltInOrFrameworkType by xtqqczze · Pull Request #14491 · PowerShell/PowerShell
xtqqczze
marked this pull request as ready for review
I doubt it is necessary. These CIM, WSMan, Counter codes are specific and frozen. All other places have already been corrected earlier. I think we should only set the severity to suggestion.
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
Maintainer review summary: ok to take this considering that this does not touch files that are frequently changed therefore the chance of introducing merge conflicts is low. Additionally, files that are not part of the build should be removed from this PR (@adityapatwardhan to give list of such files).
The files that are not compiled and hence should be removed from PR. Files to be removed:
PdhHelper.cs
CounterSample.cs
GetCounterCommand.cs
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
@adityapatwardhan The suggested changes have been made, please could you continue your review.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I like the consistency even though it is a lot of code change.
iSazonov
added
the
CL-CodeCleanup
label
xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request
xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request