◐ Shell
clean mode source ↗

Enable IDE0049: PreferBuiltInOrFrameworkType by xtqqczze · Pull Request #14491 · PowerShell/PowerShell

@xtqqczze xtqqczze marked this pull request as ready for review

December 23, 2020 22:26

@iSazonov

I doubt it is necessary. These CIM, WSMan, Counter codes are specific and frozen. All other places have already been corrected earlier. I think we should only set the severity to suggestion.

@ghost

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan

@ghost

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@anmenaga

Maintainer review summary: ok to take this considering that this does not touch files that are frequently changed therefore the chance of introducing merge conflicts is low. Additionally, files that are not part of the build should be removed from this PR (@adityapatwardhan to give list of such files).

@adityapatwardhan

The files that are not compiled and hence should be removed from PR. Files to be removed:

PdhHelper.cs
CounterSample.cs
GetCounterCommand.cs

@ghost

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

xtqqczze commented

May 8, 2021

edited by unfurl-links Bot

Loading

@xtqqczze

@adityapatwardhan The suggested changes have been made, please could you continue your review.

iSazonov

@xtqqczze

iSazonov

rkeithhill

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like the consistency even though it is a lot of code change.

@iSazonov iSazonov added the CL-CodeCleanup

Indicates that a PR should be marked as a Code Cleanup change in the Change Log

label

Jun 28, 2021

adityapatwardhan

@adityapatwardhan

@xtqqczze

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request

Sep 25, 2025

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request

Oct 9, 2025