Add missing resource strings for Get-WinEvent by MartinGC94 · Pull Request #27397 · PowerShell/PowerShell
PR Summary
The parameters for Get-WinEvent refer to help strings that don't actually exist.
This PR fixes that by adding the missing strings.
The text was copy+pasted from the existing help text (with some minor editing to cut out unnecessary details).
PR Context
Fixes: #27393
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header - This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
- Breaking changes
- None
- OR
- Experimental feature(s) needed
- Experimental feature name(s):
- User-facing changes
- Not Applicable
- OR
- Documentation needed
- Issue filed:
- Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
Copilot AI review requested due to automatic review settings
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds the missing GetEventResources entries referenced by Get-WinEvent parameter attributes so parameter-help lookup and tab completion can resolve those strings instead of hitting the missing-resource assertion described in issue #27393.
Changes:
- Added new resource strings for
Get-WinEventparameter help text inGetEventResources.resx. - Covered the missing help IDs for log, provider, path, max events, and computer name parameters.
- Centralized the fix in the diagnostics resource file used by the cmdlet metadata.
Comment on lines +288 to +289
| <data name="ListLogParamHelp" xml:space="preserve"> | ||
| <value>Specifies the event logs. Wildcards are permitted.</value> |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinGC94 Could you please fixes those 2 typos in the resource strings pointed out by Copilot? I will merge after that.
daxian-dbw
added
the
CL-General
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!