Specify 'linux-arm64' runtime if package type is 'deb-arm64' in packaging.psm1 by anamnavi · Pull Request #27401 · PowerShell/PowerShell
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Conversation
PR Summary
Add condition to specify Runtime as linux-arm64 for New-PSOptions call, if PackageType is deb-arm64. Without this, the runtime gets set as the default linux-x64 runtime which causes packaging to fail for debian arm64.
Packaging improvements:
- Added handling for the
deb-arm64package type in theStart-PSPackagefunction, enabling the creation of ARM64 Debian packages by specifying thelinux-arm64runtime.
PR Context
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header - This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
- Breaking changes
- None
- OR
- Experimental feature(s) needed
- Experimental feature name(s):
- User-facing changes
- Not Applicable
- OR
- Documentation needed
- Issue filed:
- Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
This pull request introduces support for a new package type in the packaging script. Specifically, it adds logic to handle the creation ofdeb-arm64packages, ensuring the correct runtime and configuration are used when building for this architecture.
Packaging improvements:
- Added a conditional branch in the
Start-PSPackagefunction withinpackaging.psm1to support thedeb-arm64package type, configuring it to use thelinux-arm64runtime in Release mode.
Copilot AI review requested due to automatic review settings
@anamnavi Can you please update the PR description to include what issue this is fixing?
anamnavi
changed the title
Add condition for Deb-arm64 type package in packaging.psm1
Specify 'linux-arm64' runtime if package type is 'deb-arm64' in packaging.psm1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters