Simplify string concatenation by jnyrup · Pull Request #27569 · PowerShell/PowerShell

PR Summary

Simplify string concatenation

PR Context

I originally wanted to fix the missing parentheses in computing the capacity, as + binds stronger than ??, but noticed that the concatenation could be done easier without StringBuilder

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed

Pull request overview

This PR refactors VtSubstring string construction to avoid StringBuilder and instead build the final string via string.Concat using spans.

Changes:

• Replaced StringBuilder-based concatenation with a single string.Concat(...) call.
• Removed manual capacity calculation / preallocation.