Add contextvars from CPython 3.8 by fanninpm · Pull Request #2950 · RustPython/RustPython
RustPython / RustPython Public
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merged
Merged
Conversation
fanninpm
commented
Aug 24, 2021
fanninpm
commented
Contributor
This is currently scaffolding for the contextvars module introduced in CPython 3.7 (see PEP 567).
I'm welcome to any suggestions on how to flesh this out.
youknowone
reviewed
vm/src/stdlib/contextvars.rs Outdated
fanninpm
commented
Aug 25, 2021
fanninpm commented
Contributor Author
CPython references:
- https://github.com/python/cpython/blob/3.8/Include/context.h
- https://github.com/python/cpython/blob/3.8/Python/context.c
- https://github.com/python/cpython/blob/3.8/Python/clinic/context.c.h
- https://github.com/python/cpython/blob/3.8/Modules/_contextvarsmodule.c
- https://github.com/python/cpython/blob/3.8/Modules/clinic/_contextvarsmodule.c.h
- https://github.com/python/cpython/blob/3.8/Include/internal/pycore_context.h
fanninpm
force-pushed
the
contextvars
branch
from
c9fd1cc to
fa665e6
Compare
fanninpm
force-pushed
the
contextvars
branch
from
fa665e6 to
5946aea
Compare
DimitrisJim
commented
Sep 30, 2021
DimitrisJim commented
Member
Bump, to you want to open an issue for the discussion on this? I think it would be better than having the discussion on the PR.
fanninpm
force-pushed
the
contextvars
branch
from
5946aea to
7748121
Compare
fanninpm
mentioned this pull request
fanninpm
force-pushed
the
contextvars
branch
from
7748121 to
7ce7c95
Compare
fanninpm
force-pushed
the
contextvars
branch
from
a0a1888 to
b0de234
Compare
fanninpm
force-pushed
the
contextvars
branch
from
7f23877 to
6084f02
Compare
fanninpm
marked this pull request as ready for review
fanninpm
force-pushed
the
contextvars
branch
from
6084f02 to
d7a2e8a
Compare
fanninpm added 8 commits
Things are going to get worse before they get better.
fanninpm
force-pushed
the
contextvars
branch
from
d7a2e8a to
307fac7
Compare
youknowone
approved these changes
youknowone
left a comment
youknowone
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasnt aware this was going. Looks good. Other people can work on here later.
youknowone
merged commit
047bab9
into
RustPython:main
fanninpm
deleted the
contextvars
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment