Implement ascii codec in Rust by coolreader18 · Pull Request #3118 · RustPython/RustPython
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Conversation
I started on this at the beginning of June, so I figured I should finish it and get it in. A large part of the refactoring is just deduplicating decoding logic between utf8 and ascii, since in both the valid subset can just be push_str()'d, and the rest passed to the error handler. The only difference is finding the invalid bytes, if any, and figuring out what the error is.
that can be merged first if it's ready and I can rebase and resolve conflicts from there.
Actually, I would like to make use of the error-handling code you have here. This can go first so I can rebase #3046 on top of your work.
Co-authored-by: Jeong YunWon <youknowone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters