wrap_index without abs by youknowone · Pull Request #3769 · RustPython/RustPython
RustPython / RustPython Public
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merged
Merged
Conversation
youknowone
commented
Jun 10, 2022
Member
used by #3755
@coolreader18 I am worrying if you had a reason to choose that form. Could you check it?
cc39e3f to
1d1ff8d
Compare
DimitrisJim
approved these changes
DimitrisJim
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm, not sure about why taking the absolute value was used initially.
qingshi163
approved these changes
qingshi163
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bf49952
into
RustPython:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
