◐ Shell
clean mode source ↗

turn on --installp-pip test by youknowone · Pull Request #3795 · RustPython/RustPython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@youknowone

@youknowone youknowone commented

Jun 16, 2022

edited

Loading

Copy link Copy Markdown

Member

close #3670

@youknowone

Copy link Copy Markdown

Member Author

hmm, what's left?

@fanninpm

Copy link Copy Markdown

Contributor

Perhaps a rebase?

@youknowone

Copy link Copy Markdown

Member Author

rebase is not helpful

@dieterplex

Copy link Copy Markdown

Contributor

Dig into get-pip.py and found that html parser not works. no links could be parsed from the page https://pypi.org/simple/pip/
I guess we should check html.parser.HTMLParser first.

Test with

> target/release/rustpython get-pip-zip-extracted/__main__.py -vvv install --upgrade --force-reinstall -t site-packages/  pip

specific source at line 353: parser.feed(page.content.decode(encoding)) from get-pip-zip-extracted/_internal/index/collector.py:parse_links().
There is no item in parser.anchor after feed.

youknowone reacted with thumbs up emoji fanninpm reacted with eyes emoji

@youknowone

Copy link Copy Markdown

Member Author

Thank you!

@youknowone

Copy link Copy Markdown

Member Author

try again

@youknowone youknowone merged commit 8ae1c70 into RustPython:main

Jul 24, 2022

@youknowone youknowone deleted the install-pip branch

July 24, 2022 21:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

issue with rustpython --install-pip

3 participants

@youknowone @fanninpm @dieterplex