◐ Shell
clean mode source ↗

Add `math.exp2` implemented in cpython 3.11 by jopemachine · Pull Request #4150 · RustPython/RustPython

@jopemachine jopemachine changed the title Added math.exp2 implemented in cpython 3.11 Add math.exp2 implemented in cpython 3.11

Sep 9, 2022

@youknowone

@jopemachine

The rust part looks great. Could you also check if you followed this guideline? RustPython/RustPython/wiki/How-to-update-test-files

Thanks for letting me know!
I just made a fixing commit.

I didn't include unrelated diffs with math.exp2 in the commit because I think including these diffs might be out of this PR's scope.

@youknowone

We usually 'sync' our version to a specific CPython version, instead of updating each function. The bulk update is easy by following the guideline.

@jopemachine

We usually 'sync' our version to a specific CPython version, instead of updating each function. The bulk update is easy by following the guideline.

Understood. I attached @unittest.expectedFailure to the expected failed tests.

This could be fixed by the other 2 PRs that I made.

youknowone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!