Return arg in case of invalid param in strftime by itsankitkp · Pull Request #4530 · RustPython/RustPython
Chrono panics in case of unsupported formats, this patch handles such cases and returns supplied format as a result.
This is re-implementation of PR: #4474
as previous PR got messed up git history
Chrono panics in case of unsupported formats, this patch handles such cases and returns supplied format as a result.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except for the comment.
you don't need to open a new pr to fix branch. please ask help next time. I can help you to fix them 😄
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
This was referenced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters