feat(configparser): update to 3.11 by carlosmiei · Pull Request #4595 · RustPython/RustPython
When I update a library from a newer version of CPython, I usually do this:
- Copy/paste the library straight from CPython unless it has any RustPython-related annotations, and put that into the first commit. (Your first commit is fine as is, but personally, I would title it
Update configparser.py from CPython 3.11in accordance with this guide.)- Copy/paste the test straight from CPython, without touching the RustPython-related annotations, and put that into a second commit, titled something like
Update test_configparser.py from CPython 3.11. (You can follow the guide in the wiki, but I use Meld for this.)- Run the new test. Add/remove any necessary RustPython-related annotations, and put that into one or more commits, titled something like
Mark failing/erroring testsorUnmark passing testsorSkip panicking test.
@fanninpm thanks for your suggestions, I was trying to follow conventional commits convention but will stick with your advice next time.