◐ Shell
clean mode source ↗

Add unittset.expectedFailureIf for RustPython by youknowone · Pull Request #4597 · RustPython/RustPython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@youknowone

Copy link Copy Markdown

Member

We really need conditional expectedFailure in the name of human right and pain killer.

DimitrisJim reacted with thumbs up emoji

@youknowone youknowone force-pushed the expected-failure-if branch 3 times, most recently from dbd367e to 27592bc Compare

March 1, 2023 09:06

@youknowone youknowone force-pushed the expected-failure-if branch from 27592bc to 77ffa85 Compare

March 1, 2023 13:31

@youknowone youknowone force-pushed the expected-failure-if branch from 77ffa85 to 367a948 Compare

March 1, 2023 19:41

@DimitrisJim DimitrisJim left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a great helper to have

@fanninpm fanninpm left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take care to remove these once all of their usages are gone.

@fanninpm fanninpm merged commit 6e4c2fe into RustPython:main

Mar 2, 2023

@youknowone youknowone deleted the expected-failure-if branch

March 2, 2023 19:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@fanninpm fanninpm fanninpm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youknowone @DimitrisJim @fanninpm