Add unittset.expectedFailureIf for RustPython by youknowone · Pull Request #4597 · RustPython/RustPython
RustPython / RustPython Public
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merged
Merged
Conversation
youknowone
commented
Feb 28, 2023
youknowone
commented
Member
We really need conditional expectedFailure in the name of human right and pain killer.
youknowone
requested a review
from fanninpm
youknowone
force-pushed
the
expected-failure-if
branch
3 times, most recently
from
dbd367e to
27592bc
Compare
youknowone
mentioned this pull request
youknowone
force-pushed
the
expected-failure-if
branch
from
27592bc to
77ffa85
Compare
youknowone
force-pushed
the
expected-failure-if
branch
from
77ffa85 to
367a948
Compare
DimitrisJim
approved these changes
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a great helper to have
fanninpm
approved these changes
fanninpm
left a comment
fanninpm
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take care to remove these once all of their usages are gone.
fanninpm
merged commit
6e4c2fe
into
RustPython:main
youknowone
deleted the
expected-failure-if
branch
DimitrisJim
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment