◐ Shell
clean mode source ↗

Update test_baseexception.py from cpython 3.11.2 by dalinaum · Pull Request #4624 · RustPython/RustPython

@fanninpm

Please break any RustPython-related lines into a separate commit. This makes the git blame easier to keep track of.

CPython Developers and others added 2 commits

March 5, 2023 03:19

@dalinaum

@fanninpm Sure, I just split the previous commit into two commits.

youknowone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

fanninpm

Comment on lines +33 to +35

inheritance_tree = open(
os.path.join(os.path.split(__file__)[0], 'exception_hierarchy.txt'),
encoding="utf-8")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing: since this references a file named exception_hierarchy.txt, it would make sense if it could also be brought up to date.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I uploaded it as a PR #4627.