◐ Shell
clean mode source ↗

Update test/test_with.py from CPython 3.11.2 by dalinaum · Pull Request #4648 · RustPython/RustPython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

youknowone

merged 2 commits into

RustPython:mainfrom

dalinaum:test_with

Mar 7, 2023

Merged

Update test/test_with.py from CPython 3.11.2#4648

youknowone

merged 2 commits into

RustPython:mainfrom

dalinaum:test_with

Conversation

@dalinaum

@dalinaum dalinaum commented

Mar 6, 2023

Copy link Copy Markdown

Contributor

#4564
Tests related to python/cpython#26809 have been marked as failing tests.

CPython Developers and others added 2 commits

March 7, 2023 04:51
A TypeError is raised instead of an AttributeError in "with" and
"async with" statements for objects which do not support the context
manager or asynchronous context manager protocols correspondingly.

See also:
python/cpython#26809

@fanninpm fanninpm left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@youknowone we should probably follow up on this change in error type.

@youknowone youknowone merged commit 3fe5a36 into RustPython:main

Mar 7, 2023

@dalinaum dalinaum deleted the test_with branch

March 7, 2023 04:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dalinaum @fanninpm @youknowone