Update test/test_with.py from CPython 3.11.2 by dalinaum · Pull Request #4648 · RustPython/RustPython
RustPython / RustPython Public
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merged
Merged
Conversation
dalinaum
commented
Mar 6, 2023
dalinaum
commented
Contributor
#4564
Tests related to python/cpython#26809 have been marked as failing tests.
CPython Developers and others added 2 commits
A TypeError is raised instead of an AttributeError in "with" and "async with" statements for objects which do not support the context manager or asynchronous context manager protocols correspondingly. See also: python/cpython#26809
fanninpm
mentioned this pull request
fanninpm
approved these changes
fanninpm
left a comment
fanninpm
left a comment
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@youknowone we should probably follow up on this change in error type.
youknowone
mentioned this pull request
youknowone
merged commit
3fe5a36
into
RustPython:main
dalinaum
deleted the
test_with
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment