◐ Shell clean mode source ↗

Update test/test_types from CPython 3.11.2 by tdub0 · Pull Request #4683 · RustPython/RustPython

tdub0

Skip to content

Merged

merged 4 commits into

RustPython:mainfrom

tdub0:test_types_modify

Mar 12, 2023

Merged

Update test/test_types from CPython 3.11.2#4683
DimitrisJim
merged 4 commits into
RustPython:mainfrom
tdub0:test_types_modify

Conversation

tdub0 commented
Mar 12, 2023

Copy link

Copy Markdown

Contributor

#4564
Changes from CPython v3.11.2 produce a single failure on a new test test_dunder_get_signature. There seems to be no signature found in builtin method __get__ of 'method_descriptor' objects, so it raises a ValueError. I added the expectedFailure decorator to that function.

tdub0 added 3 commits

March 11, 2023 16:26

Update test_types.py from CPython v3.11.2

exp failure on new dunder sig test

specify failure reason

DimitrisJim reviewed Mar 12, 2023

View reviewed changes

Lib/test/test_types.py Outdated

fix todo for RustPython

DimitrisJim approved these changes Mar 12, 2023

View reviewed changes

DimitrisJim left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

DimitrisJim mentioned this pull request

Update python libraries and tests from CPython 3.11 #4564

Closed

DimitrisJim merged commit f583f9a into RustPython:main

tdub0 deleted the test_types_modify branch

March 12, 2023 23:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants