◐ Shell
clean mode source ↗

Update test_string.py from Cpython v3.11.2 by jiwahn · Pull Request #4751 · RustPython/RustPython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jiwahn

@jiwahn jiwahn commented

Mar 25, 2023

edited

Loading

Copy link Copy Markdown

Contributor

#4564 update test_string.py from Cpython v3 with expectedFailure

@youknowone youknowone merged commit 09c2dc2 into RustPython:main

Mar 25, 2023

@youknowone youknowone added A-stdlib z-ca-2023

Tag to track contrubution-academy 2023

labels

Mar 25, 2023
Comment thread

Lib/test/test_string.py

Comment on lines +478 to +479

# TODO: RUSTPYTHON
@unittest.expectedFailure

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowone This should have been broken out into a separate commit.

Comment thread

Lib/test/test_string.py

Comment on lines +501 to +502

# TODO: RUSTPYTHON
@unittest.expectedFailure

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowone This should have been broken out into a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

A-stdlib z-ca-2023

Tag to track contrubution-academy 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiwahn @youknowone @fanninpm