◐ Shell
clean mode source ↗

update test_builtin.py from cpython v3.11.2 by JaeyoungAhn · Pull Request #4765 · RustPython/RustPython

@JaeyoungAhn

#4564 update test_builtin.py from cpython v3.11.2

DimitrisJim

@DimitrisJim

thanks! There's some additional regressions here which should be noted: test_delattr, test_getattr, test_hasattr and test_setattr should probably all be related. test_type_name is also failing now.

DimitrisJim

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully should be good to go now.

youknowone

(' ', ValueError),
(' \t\t ', ValueError),
# (str(br'\u0663\u0661\u0664 ','raw-unicode-escape'), 314), XXX RustPython
(str(br'\u0663\u0661\u0664 ','raw-unicode-escape'), 314),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

self.assertEqual(type(round(x, None)), type(round(x)))

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing this one is looking like a good first issue

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +526 to +527

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +760 to +761

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +794 to +795

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +815 to +816

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +839 to +840

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +950 to +951

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +963 to +964

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.

fanninpm

Comment on lines +2413 to +2414

# TODO: RUSTPYTHON
@unittest.expectedFailure

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitrisJim I believe this should have been broken out into a separate commit.