Update test_cmd_line from Cpython v3.11.2 by Masorubka1 · Pull Request #4801 · RustPython/RustPython

DimitrisJim

A couple of successes:

UNEXPECTED SUCCESS: test_optimize (test.test_cmd_line.CmdLineTest.test_optimize)
UNEXPECTED SUCCESS: test_output_newline (test.test_cmd_line.CmdLineTest.test_output_newline)
UNEXPECTED SUCCESS: test_site_flag (test.test_cmd_line.CmdLineTest.test_site_flag)

and a couple of failures:

FAIL: test_tokenizer_error_with_stdin (test.test_cmd_line.SyntaxErrorTests.test_tokenizer_error_with_stdin)
FAIL: test_decoding_error_at_the_end_of_the_line (test.test_cmd_line.SyntaxErrorTests.test_decoding_error_at_the_end_of_the_line)
FAIL: test_xoption_frozen_modules (test.test_cmd_line.CmdLineTest.test_xoption_frozen_modules) []
FAIL: test_xoption_frozen_modules (test.test_cmd_line.CmdLineTest.test_xoption_frozen_modules) [=]
FAIL: test_xoption_frozen_modules (test.test_cmd_line.CmdLineTest.test_xoption_frozen_modules) [=on]
FAIL: test_int_max_str_digits (test.test_cmd_line.CmdLineTest.test_int_max_str_digits)
FAIL: test_help_xoptions (test.test_cmd_line.CmdLineTest.test_help_xoptions)
FAIL: test_help_env (test.test_cmd_line.CmdLineTest.test_help_env)
FAIL: test_help_all (test.test_cmd_line.CmdLineTest.test_help_all)
FAIL: test_help (test.test_cmd_line.CmdLineTest.test_help)
ERROR: test_non_interactive_output_buffering (test.test_cmd_line.CmdLineTest.test_non_interactive_output_buffering)

		b"'abc\\n'")

		# TODO: RUSTPYTHON
		@unittest.skipIf(sys.platform.startswith('win'), "TODO: RUSTPYTHON windows has \n troubles")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other tests are marked TODO: RUSTPYTHON, universal newlines, but I like this description better, as it's a clearer statement of the problem.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this can probably be opened as an issue, seems like it wouldn't be too difficult to fix.

2 more windows issues

FAIL: test_output_newline (test.test_cmd_line.CmdLineTest.test_output_newline)
FAIL: test_stdin_readline (test.test_cmd_line.CmdLineTest.test_stdin_readline)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm!