◐ Shell
clean mode source ↗

Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib by Masorubka1 · Pull Request #4835 · RustPython/RustPython

@Masorubka1

  1. split hashlib and _hashlib
  2. add libraries: _md5, _sha1, _sha3, _sha256, _blake2
  3. add tests for hashlib

@fanninpm

@youknowone

hashlib.py strongly supposes _hashlib is cpython-like openssl implementation. It will require efforts.
In my opinion, that's more like test-purpose compatibility rather than actual compatiblity. But I will happily take patch if anyone want to work on it.

@Masorubka1 Masorubka1 changed the title Update test_hashlib.py from Cpython v3.11.2 [WIP] Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib

Apr 9, 2023

@Masorubka1 Masorubka1 changed the title [WIP] Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib

Apr 16, 2023

@Masorubka1

fanninpm

youknowone

youknowone

youknowone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, You made it 👍
Looks mostly good. I left a few comments.

fanninpm

youknowone

youknowone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is great, I like it very much!