◐ Shell
clean mode source ↗

Allow uuid on wasm32 and wasi by youknowone · Pull Request #4965 · RustPython/RustPython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@youknowone

@youknowone youknowone commented

May 11, 2023

edited

Loading

Copy link Copy Markdown

Member

DimitrisJim reacted with thumbs up emoji

@lastmjs

lastmjs commented

May 11, 2023

Copy link Copy Markdown

I wonder if _signal will be a dependency of other modules though, since signal depends on _signal. This just came up when including uuid.

@lastmjs

lastmjs commented

May 11, 2023

Copy link Copy Markdown

It worked for uuid though!

@youknowone

Copy link Copy Markdown

Member Author

It will be eventually need to be implemented.
platform unnecessarily requires subprocess. and subprocess requires signal.
If you find any problem with platform, It can be also quickly patched.
signal module will take time

@youknowone youknowone merged commit 698134c into RustPython:main

May 11, 2023

@youknowone youknowone deleted the wasmuuid branch

May 11, 2023 17:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youknowone @lastmjs