◐ Shell
clean mode source ↗

Complement vm logics related with `ParamSpec` and `TypeVarTuple` by moreal · Pull Request #5505 · RustPython/RustPython

@moreal

This pull request complements compiler, vm logics related PEP-0695.

@moreal moreal changed the title Implement vm logics related with ParamSpec and TypeVarTuple Complement vm logics related with ParamSpec and TypeVarTuple

Feb 6, 2025

@moreal moreal marked this pull request as ready for review

February 7, 2025 01:04

youknowone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!
Is there any related test about this changes in test_typing?

(okay if there is nothing or not the full test is passed yet)

@moreal

@youknowone PEP-0695 is applied since Python 3.12 and current typing module (on main branch) is on Python 3.10.5. So I guess there are no related tests about this pull request.

Also, this pull request is originally part of #5486 but I am separating this commit from the PR for ease of review. There are more works for marking #5486 as ready-to-review 😞

error: Python compile error from Lib/test/test_typing.py: cannot use starred expression here at row 1081 col 25
  --> pylib/src/lib.rs:14:35
   |
14 |     rustpython_derive::py_freeze!(dir = "./Lib", crate_name = "rustpython_compiler_core");
   |                                   ^^^^^^^^^^^^^

error: could not compile `rustpython-pylib` (lib) due to 1 previous error

youknowone

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, got it. Thank you for explanation!