◐ Shell clean mode source ↗

Fix bz2 module by arihant2math · Pull Request #5605 · RustPython/RustPython

arihant2math

Skip to content

Closed

wants to merge 10 commits into

RustPython:mainfrom

arihant2math:bz2-rs

Closed

Fix bz2 module#5605
arihant2math
wants to merge 10 commits into
RustPython:mainfrom
arihant2math:bz2-rs

Conversation

arihant2math commented
Mar 13, 2025
•

edited

Loading

Copy link

Copy Markdown

Contributor

The new libbz2-rs-sys is a rust only implementation of bz2. This is similar to #5562.

Blog post: https://trifectatech.org/blog/translating-bzip2-with-c2rust/

arihant2math marked this pull request as draft

March 13, 2025 15:51

arihant2math force-pushed the bz2-rs branch from a5f7fb8 to c67fe4a Compare

March 24, 2025 00:44

arihant2math mentioned this pull request

Update Python libraries and tests from Python 3.13 #5529

Closed

arihant2math force-pushed the bz2-rs branch from fbe1cef to 8325671 Compare

April 1, 2025 02:40

arihant2math mentioned this pull request

stdlib compatability checking scripts #5697

Merged

arihant2math added 5 commits

April 15, 2025 14:52

fix bz2 module

try and fix some stuff

arihant2math force-pushed the bz2-rs branch from 8325671 to 1456313 Compare

April 15, 2025 21:53

arihant2math added 3 commits

April 15, 2025 15:10

fix test_codecs

fix test_tarfile

arihant2math marked this pull request as ready for review

April 15, 2025 22:30

arihant2math added 2 commits

April 15, 2025 15:31

arihant2math commented
Apr 15, 2025

Copy link

Copy Markdown

Contributor Author

@youknowone ready for merge

youknowone requested changes Apr 17, 2025

View reviewed changes

Lib/test/test_bz2.py

		self.assertRaises(TypeError, BZ2File, os.devnull, "r", 3)

		# TODO: RUSTPYTHON
		@unittest.expectedFailure

youknowone
Apr 17, 2025
•

edited

Loading

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we go this way if it occures these many regressions?
If this can be fixed in future, let's fix it first and merge it later.
Otherwise this must be an optional feature for specific requirements.

fanninpm mentioned this pull request

Switch to libbz2-rs-sys and finish bz2 impl #5709

Merged

arihant2math closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants