Failure marker by arihant2math · Pull Request #5695 · RustPython/RustPython
Currently I need to patch it a little ... but the idea is that the workflow is the following:
- Make some changes to Lib/ and Lib/test/
- Find which tests are failing
- Run
python ./scripts/fix_test.py --test test_venv --path ./Lib/test/test_venv.pyor equivalent for the test from the project root. - Actually fix the test.
This works best for platform-independent tests.
The limitations are:
- Can't handle unexpected successes (I could fix this, but this is rare enough, I think it's fine
- Can't handle entire test file crashes (this is another thing the user has to handle themselves)
- Can't handle subclasses and nested classes etc. (I'm working on a fix for this though)
Having a working --junit-xml would help with finding failing tests, instead of parsing stdout.
Because some tests like printing out to stdout, ruining the parser.
#4072 is the blocking issue.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the comment to the header of the script as documentation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters