Cleanup match statement codegen by arihant2math · Pull Request #5700 · RustPython/RustPython

arihant2math

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! lmk when you feel it's ready to be merged.

Comment on lines +1947 to +1952

		match n {
		// If no name is provided, simply pop the top of the stack.
		None => {
		emit!(self, Instruction::Pop);
		Ok(())
		}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also use let-else, to prevent rightward drift.

        let Some(name) = n else {
            // If no name is provided, simply pop the top of the stack.
            emit!(self, Instruction::Pop);
            return Ok(());
        };

		@@ -2155,10 +2158,7 @@ impl Compiler<'_> {
		for ident in attrs.iter().take(n_attrs).skip(i + 1) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't the code you changed, but if you're looking to make it more rusty, you could use .enumerate() here for the outer loop (for (i, attr) in attrs.iter().enumerate()) and then just for ident in &attrs[i + 1..] for the inner loop.