Implement nt.listvolumes by arihant2math · Pull Request #5730 · RustPython/RustPython
youknowone
changed the title
More nt implementation
nt.listvolumes
nt._path_exists doesn't look like to be included here.
I will not retrigger CI because nt is not related to ubuntu build
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was there any related test for listvolumes?
was there any related test for listvolumes?
Yes, but it requires a different os function that doesn't exist, so it still fails.
arihant2math
changed the title
nt.listvolumes
Implement nt.listvolumes
| #[pyfunction] | ||
| fn listvolumes(vm: &VirtualMachine) -> PyResult<PyListRef> { | ||
| let mut volumes = vec![]; | ||
| let mut buffer = [0u16; 257]; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is related to constant, is this possible?
| let mut buffer = [0u16; 257]; | |
| let mut buffer = [0u16; MAX_PATH + 1]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters