◐ Shell
clean mode source ↗

Impl PyAttributeError args by youknowone · Pull Request #5805 · RustPython/RustPython

coderabbitai

Walkthrough

The updates unify the creation and handling of AttributeError exceptions across the codebase by introducing a new new_no_attribute_error method in the virtual machine. All relevant error-raising locations now use this method to generate attribute errors with contextual information. Corresponding tests are updated to expect passing behavior.

Changes

File(s) Change Summary
Lib/test/test_exceptions.py Removed @unittest.expectedFailure and comment from two tests, making them standard passing tests.
vm/src/builtins/descriptor.rs Replaced generic AttributeError creation with vm.new_no_attribute_error for missing slots.
vm/src/exceptions.rs Removed impl flag from #[pyexception] on PyAttributeError; added explicit impl with slot_init for attribute initialization.
vm/src/protocol/object.rs Replaced manual AttributeError creation with vm.new_no_attribute_error in attribute access and deletion.
vm/src/vm/method.rs Simplified missing attribute error handling to use vm.new_no_attribute_error.
vm/src/vm/vm_new.rs Added new_no_attribute_error method to VirtualMachine to create contextual AttributeError.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant VM
    participant PyObject
    participant Exception

    User->>PyObject: Access or delete attribute
    PyObject->>VM: Attribute not found
    VM->>VM: new_no_attribute_error(obj, attr_name)
    VM->>Exception: Create AttributeError with context
    Exception-->>User: Raise AttributeError with name and obj
Loading

Poem

In the warren of code, a new path appears,
Attribute errors now crystal clear!
No more patchwork, just one rabbit hop,
With context and clarity, we never stop.
🐇✨
Bugs beware, for this hop is neat—
AttributeError’s journey is now complete!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27b9b5e and 86cdbcc.

📒 Files selected for processing (6)
  • Lib/test/test_exceptions.py (0 hunks)
  • vm/src/builtins/descriptor.rs (1 hunks)
  • vm/src/exceptions.rs (1 hunks)
  • vm/src/protocol/object.rs (1 hunks)
  • vm/src/vm/method.rs (1 hunks)
  • vm/src/vm/vm_new.rs (1 hunks)
💤 Files with no reviewable changes (1)
  • Lib/test/test_exceptions.py
🚧 Files skipped from review as they are similar to previous changes (5)
  • vm/src/builtins/descriptor.rs
  • vm/src/vm/method.rs
  • vm/src/exceptions.rs
  • vm/src/vm/vm_new.rs
  • vm/src/protocol/object.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run tests under miri
  • GitHub Check: Ensure compilation on various targets
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.