◐ Shell
clean mode source ↗

Fix posix tests by youknowone · Pull Request #5811 · RustPython/RustPython

youknowone

Walkthrough

The changes remove @unittest.expectedFailure decorators from several tests in Lib/test/test_posix.py, indicating these tests are no longer expected to fail. In vm/src/stdlib/posix.rs, the environment variable handling is refactored, and support for new posix_spawn attributes (setpgroup, resetids, setsid, setsigmask, scheduler) is added, with corresponding logic for each.

Changes

File(s) Change Summary
Lib/test/test_posix.py Removed @unittest.expectedFailure decorators and related TODO comments from multiple test methods in _PosixSpawnMixin.
vm/src/stdlib/posix.rs Refactored environment dict handling; added and implemented support for new posix_spawn attributes: setpgroup, resetids, setsid, setsigmask, and scheduler.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant PosixSpawnArgs
    participant libc

    Caller->>PosixSpawnArgs: spawn()
    alt setpgroup provided
        PosixSpawnArgs->>libc: posix_spawnattr_setpgroup
    end
    alt resetids true
        PosixSpawnArgs->>libc: set POSIX_SPAWN_RESETIDS flag
    end
    alt setsid true (Linux)
        PosixSpawnArgs->>libc: set POSIX_SPAWN_SETSID flag
    else setsid true (Other)
        PosixSpawnArgs-->>Caller: NotImplementedError
    end
    alt setsigmask provided
        PosixSpawnArgs->>libc: posix_spawnattr_setsigmask
    end
    alt scheduler provided
        PosixSpawnArgs-->>Caller: NotImplementedError
    end
    PosixSpawnArgs->>libc: posix_spawnattr_setflags (if any flags set)
    PosixSpawnArgs->>libc: posix_spawn / posix_spawnp
    libc-->>PosixSpawnArgs: pid
    PosixSpawnArgs-->>Caller: pid
Loading

Poem

In the warren of code, new features appear,
Spawn flags and signals, the path is now clear.
No more expected failures, the tests now all pass,
With posixy options, our rabbits have class!
🐇✨

Onward we hop, with attributes in tow—
The burrow grows stronger, as features now flow!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dde4302 and 151598c.

📒 Files selected for processing (1)
  • vm/src/stdlib/posix.rs (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • vm/src/stdlib/posix.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Ensure compilation on various targets
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.