◐ Shell
clean mode source ↗

Remove redundent `to_owned()` and `to_string()` calls by ShaharNaveh · Pull Request #5836 · RustPython/RustPython

ShaharNaveh

Walkthrough

This change uniformly removes unnecessary .to_owned() and similar string ownership conversions from error message strings passed to error constructors throughout the codebase. Instead of creating owned String objects from string literals, string slices are now passed directly, simplifying error message construction without altering logic, control flow, or error handling.

Changes

File(s) Change Summary
stdlib/src/array.rs, stdlib/src/binascii.rs, ... Removed .to_owned()/.to_string() from error message strings, passing string slices directly to error constructors throughout all affected modules and files. No logic or control flow changes.
vm/src/builtins/asyncgenerator.rs, vm/src/builtins/bool.rs, ... Same pattern applied to builtins and VM modules: error messages now use string slices instead of owned strings for all error creation calls.
vm/src/stdlib/ctypes.rs, vm/src/stdlib/ctypes/base.rs, ... Uniform simplification of error message construction by eliminating unnecessary string allocations in ctypes and related modules.
(All other listed files) Consistent application of the same refactoring: error messages are passed as string slices, not owned strings, across all modules.

Possibly related PRs

  • RustPython/RustPython#5820: Also modifies stdlib/src/binascii.rs, introducing new arguments and logic to the hexlify function; related through changes to the same function and file.
  • RustPython/RustPython#5826: Focuses on removing unnecessary string ownership conversions in error message construction, including in stdlib/src/array.rs, closely related in approach and affected files.
  • RustPython/RustPython#5823: Modifies vm/src/builtins/function.rs, introducing new constructor logic; related by file and context, though with different focus.

Suggested reviewers

  • youknowone

Poem

A bunny hopped through fields of code,
Snipping .to_owned() where it showed.
Now strings are light, no clones in sight,
Error messages swift as flight!
With every slice, the code feels nice—
Simpler, leaner, pure delight!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.