◐ Shell
clean mode source ↗

Fix type_params lifetime in symboltable by youknowone · Pull Request #5844 · RustPython/RustPython

youknowone

Walkthrough

This update removes the @unittest.expectedFailure decorators from several protocol-related tests in Lib/test/test_typing.py, enabling these tests to run and validate protocol and generic behaviors. Additionally, minor comment corrections regarding "column-major order" are made in memory handling code, and a Rust function receives the #[track_caller] attribute for improved error tracking.

Changes

File(s) Change Summary
Lib/test/test_typing.py Removed @unittest.expectedFailure from protocol/generic tests; uncommented protocol test code.
compiler/codegen/src/compile.rs Added #[track_caller] to unwrap_internal; adjusted symbol table pop timing in class compilation.
vm/src/builtins/memory.rs
vm/src/protocol/buffer.rs		 Updated comments to refer to "column-major order" instead of "fortain order".

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant TypingProtocolTests
    TestRunner->>TypingProtocolTests: Run protocol/generic protocol tests
    TypingProtocolTests->>TypingProtocolTests: Perform runtime checks, subclass checks, instantiation checks
    TypingProtocolTests-->>TestRunner: Report test results
Loading

Possibly related PRs

  • typing.TypeVar #5834: Removes @unittest.expectedFailure decorators from typing tests in Lib/test/test_typing.py, similar to this PR.
  • typing ParamSpec #5837: Also enables previously disabled typing-related tests by removing @unittest.expectedFailure decorators in the same file.
  • more typing #5840: Activates protocol-related typing tests in test_typing.py by removing @unittest.expectedFailure decorators, closely mirroring this PR's focus.

Suggested reviewers

  • arihant2math

Poem

In a warren of tests, some failures were planned,
But now those old markers are swept from the land!
Protocols hop freely, their checks running true,
With column-major order, our comments renew.
Rust and Python together, in harmony sing—
Enabled and tidy, let the green checkmarks spring!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.