Update isintance by youknowone · Pull Request #5868 · RustPython/RustPython

youknowone

Walkthrough

A public accessor method args() was added to the PyUnion struct for direct access to its internal tuple of arguments. The is_subclass and is_instance methods in PyObject were updated to use direct downcasting and the new accessor for union type checks, simplifying and unifying the handling of unions and tuples.

Changes

File(s)	Change Summary
vm/src/builtins/union.rs	Added `pub fn args(&self) -> &PyTupleRef` to `PyUnion` for direct access to the `args` field.
vm/src/protocol/object.rs	Updated `is_subclass` and `is_instance` to downcast to `PyUnion` and use `args()` for checks; unified tuple handling.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant PyObject
    participant PyUnion

    Caller->>PyObject: is_subclass(cls)
    alt cls is PyUnion
        PyObject->>PyUnion: args()
        PyObject->>PyObject: is_subclass(member) for each member in args
    else cls is tuple
        PyObject->>PyObject: is_subclass(member) for each member in tuple
    else
        PyObject->>PyObject: __subclasscheck__ or default check
    end

Possibly related PRs

RustPython/RustPython#5855: Adds the same args() accessor and updates union handling in is_subclass and is_instance, directly refining the code in this PR.

Poem

A tuple of unions, a method anew,
Now args() reveals what unions construe.
Subclass and instance, with checks more direct,
No more indirection—just what you'd expect!
With code now more clear,
The rabbit gives cheer:
🐇 "Union logic, hop-hop, perfect!"

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.