typing _Py_subs_paramters by youknowone · Pull Request #5880 · RustPython/RustPython

coderabbitai

Walkthrough

This update refines the handling of unpacked generic alias arguments and type variable substitution in PyGenericAlias. It introduces new methods for tuple argument construction and unpacking, adjusts substitution logic for stricter argument matching, and modifies iteration to yield a single starred alias, aligning behavior more closely with CPython.

Changes

File(s)	Change Summary
vm/src/builtins/genericalias.rs	Added `with_tuple_args` constructor, `__typing_unpacked_tuple_args__` property, and `unpack_args` helper. Refactored `subs_parameters` for stricter argument handling and improved substitution. Updated iteration to yield a single starred alias. Added clarifying comments and generalized error messages.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant PyGenericAlias
    participant VM

    Caller->>PyGenericAlias: with_tuple_args(origin, args, starred, vm)
    PyGenericAlias->>VM: (constructs alias with starred flag)
    Caller->>PyGenericAlias: subs_parameters(alias, args, parameters, item, vm)
    PyGenericAlias->>PyGenericAlias: unpack_args(item, vm)
    PyGenericAlias->>PyGenericAlias: __typing_prepare_subst__ (on each parameter)
    PyGenericAlias->>PyGenericAlias: Validate argument count
    PyGenericAlias->>PyGenericAlias: Substitute parameters (using __typing_subst__ or subs_tvars)
    PyGenericAlias->>Caller: Return substituted tuple

Possibly related PRs

RustPython/RustPython#5841: Refactors the subs_parameters function and related substitution logic in genericalias.rs, focusing on improved generic alias parameter handling, directly overlapping with the changes here.

Poem

In the warren of types, a tuple unfurls,
Starred and unpacked, as logic whirls.
Arguments counted, substitutions made,
The rabbit ensures no detail will fade.
With stricter checks and aliases bright,
Type magic hops on through the night! 🐇✨

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.