◐ Shell
clean mode source ↗

type.__type_params__ by youknowone · Pull Request #5882 · RustPython/RustPython

coderabbitai

Walkthrough

The changes introduce a new property __type_params__ with getter and setter methods to the PyType class, add logic to handle starred expressions in type annotations within the compiler, and update the spell checker configuration to ignore files in target directories. No changes were made to public APIs.

Changes

File(s) Change Summary
.cspell.json Added "target/**" to ignorePaths to exclude target directories from spell checking.
compiler/codegen/src/compile.rs Updated compile_annotation to handle starred expressions in type annotations, emitting UnpackSequence.
vm/src/builtins/type.rs, vm/src/vm/context.rs Added __type_params__ property with getter and setter to PyType, enforcing tuple type and disallowing delete; added __type_params__ constant name to VM context.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Compiler
    participant Bytecode

    User->>Compiler: Provide annotation (possibly starred)
    Compiler->>Compiler: Check if annotation is starred
    alt Starred Expression
        Compiler->>Compiler: Compile inner value
        Compiler->>Bytecode: Emit UnpackSequence(1)
    else Non-starred
        Compiler->>Bytecode: Compile annotation directly
    end
Loading 
sequenceDiagram
    participant User
    participant PyType

    User->>PyType: Get __type_params__
    PyType->>PyType: Return tuple if exists, else empty tuple

    User->>PyType: Set __type_params__ (to tuple)
    PyType->>PyType: Store tuple

    User->>PyType: Delete __type_params__
    PyType->>User: Raise TypeError
Loading

Poem

In the warren, code hops anew,
Type params guarded, as rabbits do.
Starred annotations now unpack with flair,
While spell-checkers skip targets with care.
A tuple of changes, neat and bright—
The code hops forward, light and right!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba8730d and be60fe9.

⛔ Files ignored due to path filters (2)
  • Lib/test/test_dataclasses.py is excluded by !Lib/**
  • Lib/test/test_typing.py is excluded by !Lib/**
📒 Files selected for processing (3)
  • compiler/codegen/src/compile.rs (1 hunks)
  • vm/src/builtins/type.rs (1 hunks)
  • vm/src/vm/context.rs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • vm/src/vm/context.rs
🚧 Files skipped from review as they are similar to previous changes (2)
  • compiler/codegen/src/compile.rs
  • vm/src/builtins/type.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run tests under miri
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.