◐ Shell
clean mode source ↗

SymbolTable::varnames, fblock by youknowone · Pull Request #5948 · RustPython/RustPython

youknowone

Warning

Rate limit exceeded

@youknowone has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 772e213 and ab14160.

📒 Files selected for processing (2)
  • compiler/codegen/src/compile.rs (25 hunks)
  • compiler/codegen/src/ir.rs (5 hunks)

Walkthrough

The changes introduce a structured mechanism for managing control flow blocks (such as loops and exception handlers) during code generation by adding an FBlockType enum and FBlockInfo struct, along with stack management methods. Code unit metadata is consolidated into a new CodeUnitMetadata struct, and variable name definition order tracking is added to the symbol table.

Changes

File(s) Change Summary
compiler/codegen/src/compile.rs Added FBlockType enum, FBlockInfo struct, and MAXBLOCKS constant; implemented push_fblock and pop_fblock methods; refactored control flow handling to use the new fblock stack; reorganized code object metadata into metadata field; updated loop and break/continue logic.
compiler/codegen/src/ir.rs Introduced CodeUnitMetadata struct consolidating code unit metadata; refactored CodeInfo to use metadata field; updated related methods and trait implementations to use the new structure; added fields for static attributes, inlined comprehensions, and fblock stack.
compiler/codegen/src/symboltable.rs Added varnames field to SymbolTable to track variable definition order; updated SymbolTableBuilder to collect and assign varnames per scope during symbol registration and scope transitions.

Sequence Diagram(s)

sequenceDiagram
    participant Compiler
    participant CodeInfo
    participant FBlockStack
    participant SymbolTable

    Compiler->>CodeInfo: Start compiling code unit
    CodeInfo->>SymbolTable: Retrieve varnames in definition order
    CodeInfo->>FBlockStack: push_fblock (on entering loop/try)
    loop For each statement
        Compiler->>FBlockStack: push_fblock/pop_fblock as control flow changes
        Compiler->>FBlockStack: Search for enclosing loop on break/continue
    end
    CodeInfo->>CodeUnitMetadata: Update metadata (names, consts, etc.)
    CodeInfo->>Compiler: Finalize code object
Loading

Possibly related PRs

  • PyCode::qualname #5929: The main PR reorganizes internal metadata by introducing a CodeUnitMetadata struct that includes a qualname field and updates CodeInfo to use this new structure, while the retrieved PR specifically adds and manages the qualname field in CodeInfo and related compilation logic; thus, both PRs modify the same qualname field within CodeInfo and its handling in the compiler code generation, making their changes directly related.

Poem

In the warren of code, new blocks take their place,
FBlocks now stack with elegant grace.
Metadata gathered, all neat in a row,
Varnames in order, like seeds we now sow.
Loop and break, with structure anew—
This bunny hops forward, compiling for you! 🐇

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.