Correctly implement `isolation_level` setter to handle deletion by ever0de · Pull Request #5983 · RustPython/RustPython

youknowone

"""

Walkthrough

The setter method for the isolation_level attribute in the Connection class was updated to accept a PySetterValue enum, allowing explicit handling of attribute assignment and deletion. The method now handles assignment, validates string values, manages autocommit transactions, and returns an error if deletion is attempted.

Changes

File(s)	Change Summary
stdlib/src/sqlite.rs	Updated `Connection::set_isolation_level` to accept `PySetterValue`, handle assignment/deletion cases, validate input, and update internal state accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Connection
    participant VM

    Caller->>Connection: set_isolation_level(value: PySetterValue, vm)
    alt value is Assignment
        Connection->>Connection: Convert value to Option<PyStrRef>
        alt Value is Some
            Connection->>Connection: Validate isolation level string
        end
        Connection->>Connection: Swap internal isolation level
        alt New value is None and not autocommit
            Connection->>Connection: Commit pending transaction
        end
    else value is Deletion
        Connection->>VM: Raise AttributeError ("cannot delete attribute")
    end

Possibly related PRs

fix(sqlite): autocommit mode transaction handling to match CPython #5918: Refactors the same set_isolation_level method to use PySetterValue for explicit assignment and deletion handling, directly modifying isolation level management in Connection.

Suggested reviewers

youknowone

Poem

In the warren of code where the queries hop,
A setter’s new logic makes bugs gently stop.
Assign or delete, now both handled right,
With enums and checks, the future is bright.
🐇✨ The isolation is set, the transactions commit,
In the garden of SQLite, everything fits!
"""

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e61317a and 6c8ae4e.

📒 Files selected for processing (1)

stdlib/src/sqlite.rs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

stdlib/src/sqlite.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run tests under miri
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Check the WASM package and demo
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Check Rust code with rustfmt and clippy
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Ensure compilation on various targets
GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Run rust tests (macos-latest)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.