Renewd DictUpdate instruction by youknowone · Pull Request #6085 · RustPython/RustPython

youknowone

Walkthrough

The changes update the DictUpdate instruction across the compiler, bytecode, and VM execution layers to accept an explicit index argument. This involves modifying the instruction's definition, updating its emission in the compiler, and changing its handling in the VM to use the provided index when updating dictionaries on the stack.

Changes

Cohort / File(s)	Change Summary
Compiler Emission Update `compiler/codegen/src/compile.rs`	The `DictUpdate` instruction is now emitted with an explicit `index: 1` argument instead of no arguments.
Instruction Definition & Usage `compiler/core/src/bytecode.rs`	The `Instruction::DictUpdate` variant is changed from a unit to a struct with an `index` field; all pattern matches and formatting updated accordingly.
VM Execution Logic `vm/src/frame.rs`	The VM now handles `DictUpdate` with an `index` argument, using it to determine which stack dictionary to update and merging items from the source mapping.

Sequence Diagram(s)

sequenceDiagram
    participant Compiler
    participant Bytecode
    participant VM
    participant Stack
    participant PyDict

    Compiler->>Bytecode: Emit DictUpdate { index }
    Bytecode->>VM: Execute DictUpdate { index }
    VM->>Stack: Pop source mapping
    VM->>Stack: Access target dict at TOS-(index-1)
    VM->>PyDict: Merge items from source mapping

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Poem

In bytecode fields where rabbits hop,
A DictUpdate now makes a stop—
With index in paw, it leaps with glee,
To update the stack more cleverly.
Dictionaries merge, mappings unite,
In code’s spring meadow, all feels right!
🐇✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.